[Webkit-unassigned] [Bug 138310] Add parsing for :role()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138310

--- Comment #9 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
Thank you for the review.

(In reply to comment #7)
> > LayoutTests/ChangeLog:18
> > +        Add parsing for :role()
> > +        https://bugs.webkit.org/show_bug.cgi?id=138310
> 
> Doubled change log here.

I will fix this.

(In reply to comment #8)
> > Source/WebCore/css/CSSGrammar.y.in:67
> > +    case ROLEFUNCTION:
> 
> I don't think you need to define a new token type.  The type "FUNCTION
> should work.
> 
> > Source/WebCore/css/CSSParser.cpp:10703
> > +            m_token = ROLEFUNCTION;
> 
> You still need this, but I think the token type could be simply FUNCTION.

If I use "FUNCTION", :role(42) will be valid because there is

"| ':' FUNCTION maybe_space maybe_unary_operator INTEGER maybe_space ')' {"

in the grammar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141118/a7cffb2a/attachment-0002.html>