[Webkit-unassigned] [Bug 138310] Add parsing for :role()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138310

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241666|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #8 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 241666
  --> https://bugs.webkit.org/attachment.cgi?id=241666
Test for case sensitivity

View in context: https://bugs.webkit.org/attachment.cgi?id=241666&action=review

Looks great. Some minor comments.

The tests look good, you'll just need to clean up the changelog.

> Source/WebCore/css/CSSGrammar.y.in:67
> +    case ROLEFUNCTION:

I don't think you need to define a new token type.  The type "FUNCTION should work.

> Source/WebCore/css/CSSParser.cpp:10703
> +            m_token = ROLEFUNCTION;

You still need this, but I think the token type could be simply FUNCTION.

> Source/WebCore/css/CSSSelector.h:162
> +            PseudoClassRole,

Uh, I should really sort this enum some day :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141118/0f720fc8/attachment-0002.html>