[Webkit-unassigned] [Bug 138720] Refactor iOS selection gestures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138720

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241522|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #5 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 241522
  --> https://bugs.webkit.org/attachment.cgi?id=241522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241522&action=review

Ok, rs=me.

Still not a fan of m_selectionBaseIsStart.
What about an enum?

    enum class SelectorAnchor {
        Start,
        End
    }
? (assuming "selection anchor" does not have another meaning in the selection code)

"beginSelectionInDirection" -> the name is also confusing. The "InDirection" is only loosely coupled with baseIsStart.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1616
> +    m_selectionBaseIsStart = baseIsStart; // FIXME: do we need to flip this for RTL?

I would find out and fix it instead of having a FIXME.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141117/ad229303/attachment-0002.html>