[Webkit-unassigned] [Bug 138786] Whitespace action menus should focus the HitTestResult and create an insertion point

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138786

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #2)
> Comment on attachment 241685 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241685&action=review
> 
> > Source/WebKit/mac/WebView/WebActionMenuController.mm:176
> > +    frame->page()->focusController().setFocusedElement(element, element->document().frame());
> > +    VisiblePosition position = renderer->positionForPoint(_hitTestResult.localPoint(), nullptr);
> > +    element->document().frame()->selection().setSelection(position);
> 
> There's a bunch of things that might need null checks here? (but I don't
> know).

I fixed this up. Thank you! http://trac.webkit.org/changeset/176220

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141117/0eb82abd/attachment-0002.html>