[Webkit-unassigned] [Bug 138786] Whitespace action menus should focus the HitTestResult and create an insertion point
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 16 17:28:40 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=138786
Tim Horton <thorton at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #241685|review? |review+
Flags| |
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 241685
--> https://bugs.webkit.org/attachment.cgi?id=241685
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=241685&action=review
> Source/WebKit/mac/WebView/WebActionMenuController.mm:176
> + frame->page()->focusController().setFocusedElement(element, element->document().frame());
> + VisiblePosition position = renderer->positionForPoint(_hitTestResult.localPoint(), nullptr);
> + element->document().frame()->selection().setSelection(position);
There's a bunch of things that might need null checks here? (but I don't know).
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141117/714dceb6/attachment-0002.html>
More information about the webkit-unassigned
mailing list