[Webkit-unassigned] [Bug 138612] [EFL] Add subtle crypto to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138612

--- Comment #9 from Csaba Osztrogonác <ossy at webkit.org> ---
(In reply to comment #7)
> Attachment 241586 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/crypto/gnutls/CryptoDigestGnuTLS.cpp:31:  Alphabetical
> sorting problem.  [build/include_order] [4]
> ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp:38: 
> CryptoAlgorithmRSA_OAEP::platformEncrypt is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming/underscores] [4]
> ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp:50: 
> CryptoAlgorithmRSA_OAEP::platformDecrypt is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming/underscores] [4]
> ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmHMACGnuTLS.cpp:34: 
> Alphabetical sorting problem.  [build/include_order] [4]
> ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:37: 
> CryptoAlgorithmAES_KW::platformEncrypt is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming/underscores] [4]
> ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:48: 
> CryptoAlgorithmAES_KW::platformDecrypt is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming/underscores] [4]
> ERROR:
> Source/WebCore/crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp:38: 
> CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign is incorrectly named. Don't
> use underscores in your identifier names.  [readability/naming/underscores]
> [4]
> ERROR:
> Source/WebCore/crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp:51: 
> CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify is incorrectly named. Don't
> use underscores in your identifier names.  [readability/naming/underscores]
> [4]
> ERROR:
> Source/WebCore/crypto/gnutls/CryptoAlgorithmRSAES_PKCS1_v1_5GnuTLS.cpp:37: 
> CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt is incorrectly named. Don't
> use underscores in your identifier names.  [readability/naming/underscores]
> [4]
> ERROR:
> Source/WebCore/crypto/gnutls/CryptoAlgorithmRSAES_PKCS1_v1_5GnuTLS.cpp:48: 
> CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt is incorrectly named. Don't
> use underscores in your identifier names.  [readability/naming/underscores]
> [4]
> ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp:38: 
> CryptoAlgorithmAES_CBC::platformEncrypt is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming/underscores] [4]
> ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp:50: 
> CryptoAlgorithmAES_CBC::platformDecrypt is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming/underscores] [4]
> Total errors found: 12 in 20 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

We can ignore these style issues, the class names is come from the original
design: Source/WebCore/crypto/algorithms/*.h . We shouldn't change them now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141117/37981a7d/attachment-0002.html>