[Webkit-unassigned] [Bug 138612] [EFL] Add subtle crypto to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138612

Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org

--- Comment #8 from Csaba Osztrogonác <ossy at webkit.org> ---
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 241352 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=241352&action=review
> > 
> > > Source/cmake/OptionsEfl.cmake:107
> > > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SUBTLE_CRYPTO OFF)
> > 
> > BTW, is there any reason SUBTLE_CRYPTO is disabled for cmake build ?
> 
> When it came to enabling SUBTLE_CRYPTO, I based my patch on bug 135798.
> There is a good reasoning why to disable it by default, and I thought we
> need this kind of solution in case of EFL, too.

Disabling in Options<Efl|Gtk>.cmake and enabling it in Features.pm
is the common way for experimental / not completed features.

Features.pm is only used by build-webkit, which is for developers and bots
to be able test experimental features too. But production builds don't use
build-webkit at all, they call cmake directly, so experimental features are
disabled for production builds. Crypto seems to be in a very early stage now,
so it shouldn't be enabled for production build yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141117/de320d07/attachment-0002.html>