[Webkit-unassigned] [Bug 138552] WK1: Support default actions for read-only text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138552

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241265|review?                     |review+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 241265
  --> https://bugs.webkit.org/attachment.cgi?id=241265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241265&action=review

Lots of stylebot comments.

> Source/WebCore/editing/DictionaryLookup.h:43
> +bool isPositionInRange(const VisiblePosition& position, Range* range);
> +bool shouldUseSelection(const VisiblePosition& position, const VisibleSelection& selection);
> +
> +PassRefPtr<Range> rangeExpandedAroundPositionByCharacters(const VisiblePosition& position, int numberOfCharactersToExpand);

isPositionInRange and rangeExpandedAroundPositionByCharacters should probably be on VisiblePosition or Range or something, they're pretty generically useful (maybe there's already something there that we can replace these with?)

> Source/WebCore/editing/DictionaryLookup.mm:29
> +#include "Document.h"

all of these should be 'import'

> Source/WebCore/editing/DictionaryLookup.mm:77
> +PassRefPtr<Range> rangeExpandedAroundPositionByCharacters(const VisiblePosition& position, int numberOfCharactersToExpand)

Remind me to make use of this in Editor, where this code was originally stolen from.

> Source/WebCore/editing/DictionaryLookup.mm:116
> +    wkExtractWordDefinitionTokenRangeFromContextualString(fullPlainTextString, rangeToPass, options);

We should probably ditch the WKSI wrappers and add some LookUp SPI headers.

> Source/WebKit/mac/WebView/WebActionMenuController.mm:297
> +static DictionaryPopupInfo performDictionaryLookupForRange(Frame* frame, Range& range, NSDictionary *options)

Can we put more of this in the WebCore?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141110/01f99932/attachment-0002.html>