[Webkit-unassigned] [Bug 138552] WK1: Support default actions for read-only text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138552

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org

--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 241265 did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:320:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:409:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.h:40:  The parameter name "position" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.h:40:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.h:41:  The parameter name "position" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.h:41:  The parameter name "selection" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.h:43:  The parameter name "position" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.h:44:  The parameter name "selection" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.h:45:  The parameter name "hitTestResult" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/DictionaryLookup.mm:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 11 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141110/ad796380/attachment-0002.html>