[Webkit-unassigned] [Bug 138534] Implement action menu support for videos

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138534

--- Comment #4 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #3)
> Comment on attachment 241226 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241226&action=review
> 
> > Source/WebCore/rendering/HitTestResult.cpp:508
> > +bool HitTestResult::isMediaThatCanBeDownloaded() const
> 
> isDownloadableMedia?
> 

I like that better! Will use.

> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401
> > +    RefPtr<WebHitTestResult> hitTestResult = WebHitTestResult::create(_hitTestResult.hitTestResult);
> 
> Shouldn't we just use hitTestResultForStage?

UGH, I hate that enum. We should use that, except we don't know the stage here unless we pass it in, and doing that would be ridiculous. Because really, you just want the hitTestResultForStage method NOT to take an enum, and to return whichever hitTestResult it can access, favoring the new one. We have a lot of spots in this file that still choose the wrong hit test result (like all of the URL methods which all favor the old one!), I think I will fix this everywhere in a follow-up patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141108/1d5b2a43/attachment-0002.html>