[Webkit-unassigned] [Bug 138534] Implement action menu support for videos

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 7 23:33:14 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=138534

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241226|review?                     |review+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 241226
  --> https://bugs.webkit.org/attachment.cgi?id=241226
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241226&action=review

> Source/WebCore/rendering/HitTestResult.cpp:508
> +bool HitTestResult::isMediaThatCanBeDownloaded() const

isDownloadableMedia?

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401
> +    RefPtr<WebHitTestResult> hitTestResult = WebHitTestResult::create(_hitTestResult.hitTestResult);

Shouldn't we just use hitTestResultForStage?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141108/10534c9e/attachment-0002.html>


More information about the webkit-unassigned mailing list