[Webkit-unassigned] [Bug 131024] [UNIX] Reorganize and cleanup main functions of GTK and EFL ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 22 10:15:44 PDT 2014


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
 Attachment #228269|review?                     |review+
               Flag|                            |

--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2014-05-22 10:16:05 PST ---
(From update of attachment 228269)
View in context: https://bugs.webkit.org/attachment.cgi?id=228269&action=review

I'm unsure how much complexity and code this saves, it doesn't look like a lot, but I you're probably a better judge of that than me. One thing that bothers me is that in theory we could use these same implementations for Gtk on Windows, say, but I guess Unix is still sensible as a name since we'd be using GNU libraries even on windows, so r=me.

> Source/WebKit2/ChangeLog:8
> +        Move main function implementation files to <process-dir>/EntryPoint/unix/ProcessNameMain.cpp

add <> around ProcessName to be clearer?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list