[Webkit-unassigned] [Bug 131024] [UNIX] Reorganize and cleanup main functions of GTK and EFL ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 23 01:34:45 PDT 2014


--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-05-23 01:35:06 PST ---
(In reply to comment #7)
> (From update of attachment 228269 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228269&action=review

Thanks for the review.

> I'm unsure how much complexity and code this saves, it doesn't look like a lot, but I you're probably a better judge of that than me. One thing that bothers me is that in theory we could use these same implementations for Gtk on Windows, say, but I guess Unix is still sensible as a name since we'd be using GNU libraries even on windows, so r=me.

Well, this is more about keeping consistency than saving code. When I moved the NEWS file to Source/WebKit2/gtk I noticed there was a MainGtk.cpp file there. And I thought Main what? it ended up being the main function of the WebProcess. When we only had one process, it probably was less confusing, but still misplaced, it should be in Source/WebKit2/WebProcess/gtk at least. Then I looked at the different main functions, and noticed that in some cases we were sharing the implementation with EFL (but with a full of ifdefs) and in others every port had its own file. So, I took a look at what apple did for the entry points, and inspired by the mac implementation I reorganized the "unix" entry points.

> > Source/WebKit2/ChangeLog:8
> > +        Move main function implementation files to <process-dir>/EntryPoint/unix/ProcessNameMain.cpp
> add <> around ProcessName to be clearer?


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list