[Webkit-unassigned] [Bug 132951] CSS JIT: Apply backtracking optimization to adjacent backtracking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132951





--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com>  2014-05-22 09:09:48 PST ---
(In reply to comment #3)

Thank you for your review!

> (From update of attachment 231508 [details])
> Looking into this in detail, I think the design is good.
> 
> Yesterday I thought we should unify solveDescendantBacktrackingActionForChild-solveAdjacentBacktrackingActionForDirectAdjacent and computeBacktrackingHeightFromDescendant-computeBacktrackingWidthFromIndirectAdjacent...but looking into this more I am less convinced.
> 
> We could templatize the functions to do that, but I think that would hurt readability. A little duplication is okay if the result is clearer.

Right.
Personally, I think this duplication represents the implementation flow simple.
There's slightly different parts. For example, `computeBacktrackingHeightFromDescendant` has a special part to assign height information to adjacent fragments.

> 
> I clear the review flag to remove the patch from the review queue until you add the tests.

I'll add test cases!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.