[Webkit-unassigned] [Bug 132951] CSS JIT: Apply backtracking optimization to adjacent backtracking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132951


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231508|review?                     |
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2014-05-16 16:45:42 PST ---
(From update of attachment 231508)
Looking into this in detail, I think the design is good.

Yesterday I thought we should unify solveDescendantBacktrackingActionForChild-solveAdjacentBacktrackingActionForDirectAdjacent and computeBacktrackingHeightFromDescendant-computeBacktrackingWidthFromIndirectAdjacent...but looking into this more I am less convinced.

We could templatize the functions to do that, but I think that would hurt readability. A little duplication is okay if the result is clearer.

I clear the review flag to remove the patch from the review queue until you add the tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.