[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132527





--- Comment #13 from Jarek Czekalski <jarekczek at poczta.onet.pl>  2014-05-17 07:29:00 PST ---
(From update of attachment 231455)
View in context: https://bugs.webkit.org/attachment.cgi?id=231455&action=review

Mario, except the thing I put yesterday there is only one more item that was not fully done along your suggestions. The rest of the hints is applied thoroughly.

Are there any additional changes needed to land it in 2.4? Because all I do is to fix the bugs in the branch containing webkit1.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:143
>> +            arguments[lastArgument += 1] = extraArgs[i];
> 
> Instead of doing this to keep the value of lastArgument outside the loop and use it later, you could use a while loop with only one iterator (e.g. "currentArgument") and then use it later to know the last argument position (e.g. currentArgument+1).
> 
> If, however, you still prefer to use the for loop, please split that statement in too so you don't use the 'lastArgument += 1' as the index for the array (that's not clear)

I find it clearer with 'i', so I only did the splitting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.