[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132527





--- Comment #12 from Jarek Czekalski <jarekczek at poczta.onet.pl>  2014-05-16 05:45:03 PST ---
Hi Mario. Thank you for your comments. I have only one thing to discuss before I proceed with applying your suggestions. 

>> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:62
>> +// Up to 2014 it was obligatory to mirror the changes from
>> +// WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp,
>> +// but the habit has been dropped: https://bugs.webkit.org/show_bug.cgi?id=132527#c6

>Again, I think this is a nice comment for the ChangeLog, but I wouldn't put it >here since the reason is quite simple anyway: The WebKit1 versions of the GTK >and EFL ports (the only ones using ATK) are no longer maintained upstream

Someone may notice similar things in these 2 places and I would like to help him by leaving a notice here. Now the files will differ significantly, but the argument still holds. And if we remove this comment, we will have no reference from this file's history (svn log) to the comment in Changelog.

Have a nice weekend!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.