[Webkit-unassigned] [Bug 130212] AX: tabindex support in SVG2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130212





--- Comment #20 from Dirk Schulze <krit at webkit.org>  2014-05-05 11:35:36 PST ---
(In reply to comment #19)
> (From update of attachment 230750 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230750&action=review
> 
> just a few comments. thanks
> 
> > LayoutTests/accessibility/svg-group-element-with-title.html:9
> > +  <g id="group1" role="group">
> 
> why is this change necessary?

<g> is not a focusable element by default anymore and should't be according to SVG2. Therefore, it needs ARIA or something else to make it an AX element.

> 
> > Source/WebCore/svg/SVGAElement.cpp:198
> > +    // If not a link we should still be able to focus the element if it has tabIndex.
> 
> if it has "a" tab index

Fixed.

> 
> > Source/WebCore/svg/SVGElement.cpp:1158
> > +    return eventTarget->hasEventListeners(eventNames().focusinEvent)
> 
> is there a reason you need to cast this to eventTarget? It seems like you could just call hasEventListeners() directly

hasEventListeners is not a const function. A const cast is needed.

> 
> > Source/WebCore/svg/SVGElement.cpp:1169
> > +    return hasFocusEventListeners()
> 
> is there a reason you need to cast this to eventTarget? It seems like you could just call hasEventListeners() directly
> 
> > Source/WebCore/svg/SVGElement.h:145
> > +    virtual short tabIndex() const override;
> 
> looks like this can probably be private

tabIndex is part of SVGElement.idl and therefore it need to be public for JSSVGElement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.