[Webkit-unassigned] [Bug 130212] AX: tabindex support in SVG2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130212





--- Comment #19 from chris fleizach <cfleizach at apple.com>  2014-05-05 09:02:10 PST ---
(From update of attachment 230750)
View in context: https://bugs.webkit.org/attachment.cgi?id=230750&action=review

just a few comments. thanks

> LayoutTests/accessibility/svg-group-element-with-title.html:9
> +  <g id="group1" role="group">

why is this change necessary?

> Source/WebCore/svg/SVGAElement.cpp:198
> +    // If not a link we should still be able to focus the element if it has tabIndex.

if it has "a" tab index

> Source/WebCore/svg/SVGElement.cpp:1158
> +    return eventTarget->hasEventListeners(eventNames().focusinEvent)

is there a reason you need to cast this to eventTarget? It seems like you could just call hasEventListeners() directly

> Source/WebCore/svg/SVGElement.cpp:1169
> +    return hasFocusEventListeners()

is there a reason you need to cast this to eventTarget? It seems like you could just call hasEventListeners() directly

> Source/WebCore/svg/SVGElement.h:145
> +    virtual short tabIndex() const override;

looks like this can probably be private

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.