No subject

I also tested (fast/css, fast/table, fast/borders) and there are no regressions.


<span class="quote">&gt; 
&gt; Why did you add this here? It's just adding technical debt that someone has
&gt; to clean up later.
&gt; </span >

I'm a bit unfamiliar with new tests when they aren't reftests. Should I remove it from TestExpectations?


<span class="quote">&gt; &gt; LayoutTests/fast/borders/mixed-border-style2.html:7
&gt; &gt; +      -moz-box-sizing: border-box;
&gt; 
&gt; You can remove this.
&gt; </span >

Coolio, will upload a new patch addressing this.



<span class="quote">&gt; 
&gt; Where did these magic numbers come from?
&gt; </span >

They came from the original patch, I tried other values but those seems to work better.


<span class="quote">&gt; &gt; Source/WebCore/rendering/RenderObject.cpp:2455
&gt; &gt; +    Operation operation = (side == BSTop || side == BSLeft) == (style == INSET) ?
&gt; &gt; +        Darken : Lighten;
&gt; 
&gt; This line doesn't need to wrap.
&gt; </span >

All in a single line then? Ok.



<span class="quote">&gt; 
&gt; Would be nice to add a comment justifying this behavior.</span >

What about '// Here we will darken the border decoration color when needed. This will yield a similar behavior as in FF.' ?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>
--1417465721.23b5512.3328--