No subject

Fri Mar 7 15:32:22 PST 2014

I also tested (fast/css, fast/table, fast/borders) and there are no regressions.

> 
> Why did you add this here? It's just adding technical debt that someone has
> to clean up later.
> 

I'm a bit unfamiliar with new tests when they aren't reftests. Should I remove it from TestExpectations?

> > LayoutTests/fast/borders/mixed-border-style2.html:7
> > +      -moz-box-sizing: border-box;
> 
> You can remove this.
> 

Coolio, will upload a new patch addressing this.

> 
> Where did these magic numbers come from?
> 

They came from the original patch, I tried other values but those seems to work better.

> > Source/WebCore/rendering/RenderObject.cpp:2455
> > +    Operation operation = (side == BSTop || side == BSLeft) == (style == INSET) ?
> > +        Darken : Lighten;
> 
> This line doesn't need to wrap.
> 

All in a single line then? Ok.

> 
> Would be nice to add a comment justifying this behavior.

What about '// Here we will darken the border decoration color when needed. This will yield a similar behavior as in FF.' ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
--1417465721.23b5512.3328
Date: Mon, 1 Dec 2014 12:28:41 -0800
MIME-Version: 1.0
Content-Type: text/html

<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:savagobr&#64;yahoo.com" title="Adenilson Cavalcanti Silva &lt;savagobr&#64;yahoo.com&gt;"> <span class="fn">Adenilson Cavalcanti Silva</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_REOPENED "
   title="REOPENED - Groove/inset/outset borders show solid if the color is black"
   href="https://bugs.webkit.org/show_bug.cgi?id=58608">bug 58608</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
               &nbsp;
           </td>
           <td>savagobr&#64;yahoo.com
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_REOPENED "
   title="REOPENED - Groove/inset/outset borders show solid if the color is black"
   href="https://bugs.webkit.org/show_bug.cgi?id=58608#c54">Comment # 54</a>
              on <a class="bz_bug_link 
          bz_status_REOPENED "
   title="REOPENED - Groove/inset/outset borders show solid if the color is black"
   href="https://bugs.webkit.org/show_bug.cgi?id=58608">bug 58608</a>
              from <span class="vcard"><a class="email" href="mailto:savagobr&#64;yahoo.com" title="Adenilson Cavalcanti Silva &lt;savagobr&#64;yahoo.com&gt;"> <span class="fn">Adenilson Cavalcanti Silva</span></a>
</span></b>
        <pre>Simon

Thanks for reviewing the patch. I will comment inline.

<span class="quote">&gt; Does this patch fix the table rendering issues that the earlier patch broke?
&gt; </span >