[Webkit-unassigned] [Bug 129480] Child elements aren't fully repainted when setting opacity from script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129480





--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-03-28 14:23:45 PST ---
(In reply to comment #10)
> (In reply to comment #7)
> 
> > (From update of attachment 228046 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=228046&action=review
> > 
> > > Source/WebCore/css/StyleResolver.cpp:1143
> > > +        style.setEffectiveOpacity(style.opacity() * parentStyle.opacity());
> > 
> > Is "parentStyle" the correct one to be getting opacity from in all cases?
> 
> Thanks for pointing this out, Simon. It shouldn't be parentStyle.opacity(), but parentStyle.effectiveOpacity(), which is the field that "accumulates" opacity and represents the combined opacity() of all the ancestors.

Not just that, but I'm not convinced that the parent element is always the one you multiply style from (assuming that parentStyle is really the parent element's style). E.g. in some configurations of positioning and opacity.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.