[Webkit-unassigned] [Bug 129480] Child elements aren't fully repainted when setting opacity from script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129480


Enrique Ocaña <eocanha at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eocanha at igalia.com




--- Comment #10 from Enrique Ocaña <eocanha at igalia.com>  2014-03-28 14:07:12 PST ---
(In reply to comment #7)

> (From update of attachment 228046 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228046&action=review
> 
> > Source/WebCore/css/StyleResolver.cpp:1143
> > +        style.setEffectiveOpacity(style.opacity() * parentStyle.opacity());
> 
> Is "parentStyle" the correct one to be getting opacity from in all cases?

Thanks for pointing this out, Simon. It shouldn't be parentStyle.opacity(), but parentStyle.effectiveOpacity(), which is the field that "accumulates" opacity and represents the combined opacity() of all the ancestors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.