[Webkit-unassigned] [Bug 129098] WebKit crashes during execution of ReplaceSelectionCommand

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129098





--- Comment #21 from Ryosuke Niwa <rniwa at webkit.org>  2014-03-28 00:50:14 PST ---
(From update of attachment 227173)
View in context: https://bugs.webkit.org/attachment.cgi?id=227173&action=review

> Source/WebCore/ChangeLog:18
> +        The following patch attempts to prevent insertion of unmovable forbidden
> +        child nodes during execution of ReplaceSelectionCommand. Additionally,
> +        it prevents the registration of undo steps for CompositeEditCommands that
> +        contain no commands (and have no effect).

Why are we doing this in the same patch?  We should split this into a separate patch if anything.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1165
> +    // A failure to unapply the last command means the text node split wasn't
> +    // the last command and warrants a crash.

Why?  It's extremely bad to crash in the release. A broken editing behavior is much better than losing all the data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.