[Webkit-unassigned] [Bug 129098] WebKit crashes during execution of ReplaceSelectionCommand

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129098


Rob Płóciennik <r.plociennik at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226682|0                           |1
        is obsolete|                            |
 Attachment #226682|review?                     |
               Flag|                            |
 Attachment #227173|[test] Proposed patch       |Proposed patch
        description|                            |
 Attachment #227173|                            |review?
               Flag|                            |




--- Comment #18 from Rob Płóciennik <r.plociennik at samsung.com>  2014-03-19 03:15:00 PST ---
Created an attachment (id=227173)
 --> (https://bugs.webkit.org/attachment.cgi?id=227173&action=review)
[test] Proposed patch

--- Comment #19 from Rob Płóciennik <r.plociennik at samsung.com>  2014-03-19 05:24:46 PST ---
(From update of attachment 227173)
The following patch, instead of undoing the whole command, attempts to avoid inserting unmovable forbidden child nodes while executing the ReplaceSelectionCommand, using a method derived from existing code.
This approach has been chosen (instead of removing the offending nodes /after/ inserting them) to prevent the registration of undo steps for commands that have no effect. This behavior has been highlighted in a new test.

--- Comment #20 from Rob Płóciennik <r.plociennik at samsung.com>  2014-03-21 07:40:51 PST ---
Any comments appreciated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.