[Webkit-unassigned] [Bug 130577] [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 26 19:09:47 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=130577
--- Comment #12 from Jinwoo Song <jinwoo7.song at samsung.com> 2014-03-26 19:10:04 PST ---
(From update of attachment 227846)
View in context: https://bugs.webkit.org/attachment.cgi?id=227846&action=review
>>>> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:91
>>>> +EAPI Eina_Bool ewk_storage_manager_all_entries_delete(Ewk_Storage_Manager *manager);
>>>
>>> How about ewk_storage_manager_delete_all ?
>>
>> According to EFL coding convention, function namespace needs to describe *object* and *specialization*.
>>
>> - namespaced code: <module>_<object>_<specializations>_<action>, example evas_object_color_get().
>>
>> In this API, I think *ewk_storage_manager* is a module and *all_entries* is an object. Actually, this API does not delete *ewk_storage_manager* object but delete *entries* in the ewk_storage_manager object.
>> One ambiguous thing is the location of *all* word. The name may be 'ewk_storage_manager_entries_delete_all'.
>
> After discussed with jinwoo,
> ewk_storage_manager_entries_clear looks better.
+1
>>>> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:101
>>>> +EAPI Eina_Bool ewk_storage_manager_entries_for_origin_delete(Ewk_Storage_Manager *manager, Ewk_Security_Origin *origin);
>>>
>>> How about just ewk_storage_manager_delete ?
>>
>> In this case, *for origin* maybe a <specializatoins>.
>
> ewk_storage_manager_entries_for_origin_del looks better.
>
> any other suggestion?
+1
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list