[Webkit-unassigned] [Bug 130577] [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130577





--- Comment #11 from Ryuan Choi <ryuan.choi at samsung.com>  2014-03-26 18:19:07 PST ---
(In reply to comment #10)
> (From update of attachment 227846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227846&action=review
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:91
> >> +EAPI Eina_Bool ewk_storage_manager_all_entries_delete(Ewk_Storage_Manager *manager);
> > 
> > How about ewk_storage_manager_delete_all ?
> 
> According to EFL coding convention, function namespace needs to describe *object* and *specialization*.
> 
>   - namespaced code: <module>_<object>_<specializations>_<action>, example evas_object_color_get(). 
> 
> In this API, I think *ewk_storage_manager* is a module and *all_entries* is an object. Actually, this API does not delete *ewk_storage_manager* object but delete *entries* in the ewk_storage_manager object.
> One ambiguous thing is the location of *all* word. The name may be 'ewk_storage_manager_entries_delete_all'.
> 
After discussed with jinwoo,
ewk_storage_manager_entries_clear looks better.

> >> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:101
> >> +EAPI Eina_Bool ewk_storage_manager_entries_for_origin_delete(Ewk_Storage_Manager *manager, Ewk_Security_Origin *origin);
> > 
> > How about just ewk_storage_manager_delete ?
> 
> In this case, *for origin* maybe a <specializatoins>.

ewk_storage_manager_entries_for_origin_del looks better.

any other suggestion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.