[Webkit-unassigned] [Bug 130391] [EFL] Page rendering is not proper when zooming and resizing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130391





--- Comment #6 from Andrzej Badowski <a.badowski at samsung.com>  2014-03-26 03:21:51 PST ---
(In reply to comment #4)
> (From update of attachment 227762 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227762&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Fixing an improper zooming in EFL WK2 by using WKPageSetPageZoomFactor via ewk_view_zoom_set
> > +        instead WKPageSetScaleFactor via ewk_view_scale_set.
> 
> page_zoom_set and scale_set is based on different requirement.
> 
> I don't object to introduce page_zoom_set but I don't want to avoid a bug of scale_set if it has.
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:240
> >> +Eina_Bool ewk_view_zoom_set(Evas_Object* ewkView, double zoomFactor)
> > 
> > It would be clear to name as *ewk_view_page_zoom_factor_set*.
> 
> We already use ewk_view_page_zoom_set for ewebkit.
> 
> If it is not important, I'd like to keep the consistency.

There is no problem other names for the proposed functions, especially if it will help keep consistency.

(In reply to comment #4)
> (From update of attachment 227762 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227762&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Fixing an improper zooming in EFL WK2 by using WKPageSetPageZoomFactor via ewk_view_zoom_set
> > +        instead WKPageSetScaleFactor via ewk_view_scale_set.
> 
> page_zoom_set and scale_set is based on different requirement.
> 
> I don't object to introduce page_zoom_set but I don't want to avoid a bug of scale_set if it has.
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:240
> >> +Eina_Bool ewk_view_zoom_set(Evas_Object* ewkView, double zoomFactor)
> > 
> > It would be clear to name as *ewk_view_page_zoom_factor_set*.
> 
> We already use ewk_view_page_zoom_set for ewebkit.
> 
> If it is not important, I'd like to keep the consistency.

There is no problem other names for the proposed functions, especially if it will help keep consistency.
As for the error function ewk_view_scale_set, it is like a slightly different problem than the solution to the reported error. I suggest turn it off as another reported error on webkit.org. I'll try to define this bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.