[Webkit-unassigned] [Bug 130391] [EFL] Page rendering is not proper when zooming and resizing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130391





--- Comment #5 from Andrzej Badowski <a.badowski at samsung.com>  2014-03-26 02:53:32 PST ---
(In reply to comment #3)
> (From update of attachment 227762 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227762&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:240
> > +Eina_Bool ewk_view_zoom_set(Evas_Object* ewkView, double zoomFactor)
> 
> It would be clear to name as *ewk_view_page_zoom_factor_set*.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:248
> > +double ewk_view_zoom_get(const Evas_Object* ewkView)
> 
> It would be clear to name as *ewk_view_page_zoom_factor_get*.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:576
> > + * Sets zoom of the current page.
> 
> s/zoom/zoom factor/
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:583
> > +EAPI Eina_Bool ewk_view_zoom_set(Evas_Object *o, double zoomFactor);
> 
> s/zoomFactor/zoom_factor
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:586
> > + * Queries the current zom factor of the page.
> 
> typo: s/zom/zoom

There is no problem other names for the proposed functions, especially if it will help keep consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.