[Webkit-unassigned] [Bug 130078] [GTK] Use GMainLoopSource for idle and timeout sources in WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130078





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-03-20 03:57:28 PST ---
(From update of attachment 227271)
View in context: https://bugs.webkit.org/attachment.cgi?id=227271&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-145
>> -    // Reset pipeline if we are sitting on READY state when timeout is reached
> 
> Can this comment be kept in the new code please?

There's already a comment about this where the new code is, see:

// Create a timer when entering the READY state so that we can free resources                                                                                                             
// if we stay for too long on READY.                                                                                                                                                      
// Also lets remove the timer if we request a state change for any state other than READY.                                                                                                
// See also https://bugs.webkit.org/show_bug.cgi?id=117354

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:33
>> +#include <wtf/gobject/GMainLoopSource.h>
> 
> Can the class be forward-declared instead?

I don't think so, members are stack allocated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.