[Webkit-unassigned] [Bug 130078] [GTK] Use GMainLoopSource for idle and timeout sources in WebCore
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 20 02:01:03 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=130078
Philippe Normand <pnormand at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #227271|review? |review+, commit-queue-
Flag| |
--- Comment #8 from Philippe Normand <pnormand at igalia.com> 2014-03-20 02:01:21 PST ---
(From update of attachment 227271)
View in context: https://bugs.webkit.org/attachment.cgi?id=227271&action=review
> Source/WebCore/ChangeLog:8
> + * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
All this can be removed if you don't plan to comment each change :)
> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-145
> - // Reset pipeline if we are sitting on READY state when timeout is reached
Can this comment be kept in the new code please?
> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:33
> +#include <wtf/gobject/GMainLoopSource.h>
Can the class be forward-declared instead?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list