[Webkit-unassigned] [Bug 129740] [EFL] Add WK2 API to control TLS error policy on WebContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129740





--- Comment #15 from Jinwoo Song <jinwoo7.song at samsung.com>  2014-03-13 21:41:06 PST ---
(From update of attachment 226289)
View in context: https://bugs.webkit.org/attachment.cgi?id=226289&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:362
> +Eina_Bool ewk_context_ignore_tls_errors_get(const Ewk_Context *ewkContext);

Regarding the naming, I would suggest 'ewk_context_tls_errors_policy_get/set()' and to add a enumeration for TLS errors policy(Ignore/Fail). 
As described in comments, this API provides the interface to control the TLS error policy.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:115
> +        if (!strcmp(path, "/index.html")) {

Why don't you use strncmp() instead of strcmp()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.