[Webkit-unassigned] [Bug 129740] [EFL] Add WK2 API to control TLS error policy on WebContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129740


Peter Molnar <pmolnar.u-szeged at partner.samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226289|0                           |1
        is obsolete|                            |
 Attachment #226289|review?                     |
               Flag|                            |
 Attachment #226695|                            |review?
               Flag|                            |




--- Comment #16 from Peter Molnar <pmolnar.u-szeged at partner.samsung.com>  2014-03-14 05:51:35 PST ---
Created an attachment (id=226695)
 --> (https://bugs.webkit.org/attachment.cgi?id=226695&action=review)
patch

(In reply to comment #15)
> (From update of attachment 226289 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226289&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.h:362
> > +Eina_Bool ewk_context_ignore_tls_errors_get(const Ewk_Context *ewkContext);
> 
> Regarding the naming, I would suggest 'ewk_context_tls_errors_policy_get/set()' and to add a enumeration for TLS errors policy(Ignore/Fail). 
> As described in comments, this API provides the interface to control the TLS error policy.

Yes, this name is definitely better, I've renamed it. Also added the enumeration you suggested.

> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:115
> > +        if (!strcmp(path, "/index.html")) {
> 
> Why don't you use strncmp() instead of strcmp()?

Currently strcmp() is used in all of these tests, so I'm trying to conform to this here, too. If you think it needs to be an strncmp(), then it would be wise to change it in all of the other tests also.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.