[Webkit-unassigned] [Bug 127361] ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127361





--- Comment #27 from Darin Adler <darin at apple.com>  2014-03-03 10:52:36 PST ---
(From update of attachment 225072)
View in context: https://bugs.webkit.org/attachment.cgi?id=225072&action=review

> Source/WebCore/css/CSSValuePool.cpp:93
> +    if (!std::isfinite(value))
> +        return createIdentifierValue(CSSValueID::CSSValueInfinite);

It’s fine to change infinity to infinite, but not good to change NaN to infinite. I suggest using std::isinf here instead of std::isfinite. Also, is it OK to change negative infinity to positive infinity?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.