[Webkit-unassigned] [Bug 127361] ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 3 10:59:58 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=127361





--- Comment #28 from Darin Adler <darin at apple.com>  2014-03-03 10:57:01 PST ---
(From update of attachment 225072)
View in context: https://bugs.webkit.org/attachment.cgi?id=225072&action=review

>> Source/WebCore/css/CSSValuePool.cpp:93
>> +        return createIdentifierValue(CSSValueID::CSSValueInfinite);
> 
> It’s fine to change infinity to infinite, but not good to change NaN to infinite. I suggest using std::isinf here instead of std::isfinite. Also, is it OK to change negative infinity to positive infinity?

Testing ought to cover more than just parsing. Which properties support "infinite" as a value? Is it correct for these large numbers to act the same as "infinite" for those? What about properties that don’t support "infinite"? Is it OK for the large number to act as if it was an illegal value?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list