[Webkit-unassigned] [Bug 134406] Custom scrollbars should not create ScrollbarPainters on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134406





--- Comment #5 from Beth Dakin <bdakin at apple.com>  2014-06-27 14:05:16 PST ---
(In reply to comment #4)
> (From update of attachment 234005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234005&action=review
> 
> > Source/WebCore/platform/Scrollbar.h:201
> > +    bool m_isCustomScrollbar;
> 
> Why protected instead of private?
> 

Oh, that was very silly. This should definitely be private, I just failed to notice that all of the other member variables were protected when I put this one next to them.

> > Source/WebCore/rendering/RenderScrollbar.cpp:45
> > +    : Scrollbar(scrollableArea, orientation, RegularScrollbar, RenderScrollbarTheme::renderScrollbarTheme(), true)
> 
> Makes me think we should use an enum instead of a bool for readability.

That would definitely look nicer. 

I'll do a follow-up cleanup here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.