[Webkit-unassigned] [Bug 134406] Custom scrollbars should not create ScrollbarPainters on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134406





--- Comment #4 from Darin Adler <darin at apple.com>  2014-06-27 13:29:34 PST ---
(From update of attachment 234005)
View in context: https://bugs.webkit.org/attachment.cgi?id=234005&action=review

> Source/WebCore/platform/Scrollbar.h:201
> +    bool m_isCustomScrollbar;

Why protected instead of private?

> Source/WebCore/rendering/RenderScrollbar.cpp:45
> +    : Scrollbar(scrollableArea, orientation, RegularScrollbar, RenderScrollbarTheme::renderScrollbarTheme(), true)

Makes me think we should use an enum instead of a bool for readability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.