[Webkit-unassigned] [Bug 131487] [GTK] Windowed plugins visibility doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131487





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-06-25 00:31:05 PST ---
(In reply to comment #5)
> (From update of attachment 229124 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229124&action=review

Thanks!

> > Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:428
> > +void PluginControllerProxy::visibilityDidChange(bool visible)
> 
> Please name the parameter isVisible.

Sure, renamed everywhere.

> > Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:619
> > +void PluginControllerProxy::windowedPluginVisibilityDidChange(bool visible, uint64_t windowID)
> 
> Please name the parameter isVisible, and I think it makes more sense to put the windowID first.

Yes, I agree, but in windowedPluginGeometryDidChange() the window id is also the last parameter, so I'll leave consistent for now.

> > Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1021
> > +    if (isParentVisible() == visible)
> > +        return;
> 
> I think you still want to call the Widget implementation.

Widget::setParentVisible() it's just m_parentVisible = visible, I'm using the same approach as ScrollView

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.