[Webkit-unassigned] [Bug 131487] [GTK] Windowed plugins visibility doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131487


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #229124|review?                     |review+
               Flag|                            |




--- Comment #5 from Anders Carlsson <andersca at apple.com>  2014-06-23 09:37:40 PST ---
(From update of attachment 229124)
View in context: https://bugs.webkit.org/attachment.cgi?id=229124&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:428
> +void PluginControllerProxy::visibilityDidChange(bool visible)

Please name the parameter isVisible.

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:619
> +void PluginControllerProxy::windowedPluginVisibilityDidChange(bool visible, uint64_t windowID)

Please name the parameter isVisible, and I think it makes more sense to put the windowID first.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1021
> +    if (isParentVisible() == visible)
> +        return;

I think you still want to call the Widget implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.