[Webkit-unassigned] [Bug 133562] Add SPI for Injected Bundle to provide user agent for a given URL
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 6 11:39:53 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=133562
Sam Weinig <sam at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #232622|review? |review-
Flag| |
--- Comment #7 from Sam Weinig <sam at webkit.org> 2014-06-06 11:40:16 PST ---
(From update of attachment 232622)
View in context: https://bugs.webkit.org/attachment.cgi?id=232622&action=review
> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:102
> + WKStringRef userAgentForURL(WKBundleFrameRef frame, WKStringRef url);
This should take a WebFrame* and API::String* and return an API::String*
> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:85
> #include <WebCore/Widget.h>
> #include <WebCore/WindowFeatures.h>
> #include <wtf/NeverDestroyed.h>
> +#include "WKBundleAPICast.h"
Needs sorting.
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2270
> +String WebPage::userAgent(WKBundleFrameRef frame, const URL& url) const
This should take a WebFrame*
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2273
> + RefPtr<API::String> urlString = API::String::create(url.string());
This should be a RefPtr<API::URL>
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2281
> + }
> + else {
> + return m_userAgent;
> + }
> +}
No need for the else block here.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list