[Webkit-unassigned] [Bug 133562] Add SPI for Injected Bundle to provide user agent for a given URL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 6 11:30:20 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133562





--- Comment #6 from WebKit Commit Bot <commit-queue at webkit.org>  2014-06-06 11:30:44 PST ---
Attachment 232622 did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:255:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:102:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2280:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2274:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2282:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:85:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 6 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list