[Webkit-unassigned] [Bug 133521] iOS8 media controls look different from iOS7 media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133521


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232589|review?                     |review+
               Flag|                            |




--- Comment #11 from Eric Carlson <eric.carlson at apple.com>  2014-06-05 19:49:29 PST ---
(From update of attachment 232589)
View in context: https://bugs.webkit.org/attachment.cgi?id=232589&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:26
> +    min-width: 260px;

Nit: odd spacing, is there a tab in here?

> LayoutTests/platform/ios-sim/media/audio-width.html:30
> +            console.log("testing...");

console.log() doesn't end up in the results.

> LayoutTests/platform/ios-sim/media/audio-width.html:33
> +            var audioPath = "../../../media/" + findMediaFile("audio", "content/test");

But: I think you can include the "../../" in the path passed to findMediaFile.

> LayoutTests/platform/ios-sim/media/audio-width.html:36
> +            runTest();

Nit: this doesn't necessarily have to be a separate function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.