[Webkit-unassigned] [Bug 133521] iOS8 media controls look different from iOS7 media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133521





--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com>  2014-06-05 19:44:13 PST ---
(From update of attachment 232589)
View in context: https://bugs.webkit.org/attachment.cgi?id=232589&action=review

Thanks for taking a look at this! -Wenson

>> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:88
>> +    background-color: rgb(0, 0, 0);
> 
> You could use the "black" keyword here.

Good catch. Fixed.

>> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:102
>> +    -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 42 44"><g fill="none"><path stroke="white" stroke-width="1" d="M15,27.5  10.5,27.5  10.5,14.5  30.5,14.5  30.5,27.5  26,27.5  30.5,27.5  30.5,14.5  10.5,14.5  10.5,27.5  15,27.5 Z" /><path fill="white" d="M20.5,23.5  13,31.5  28,31.5" /></g></svg>');
> 
> There are more spaces between path data elements in this one and the one above than the others. Intentional?

It was intentional, for the purpose of readability (the other paths were generally simple enough that reading the points wasn't too difficult)

>> LayoutTests/platform/ios-sim/media/audio-width.html:1
>> +
> 
> There's an extra newline here

Fixed. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.