[Webkit-unassigned] [Bug 133512] [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133512





--- Comment #5 from Mario Sanchez Prada <mario at webkit.org>  2014-06-05 10:12:12 PST ---
(In reply to comment #4)
> (From update of attachment 232484 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232484&action=review
> 
> Looks like the fix is not entirely platform-specific, but the tests are.
> Any way we can do tests that can run on the other platforms too?
> 
You are perfectly right. Sorry I did not realize of this before and focus just in reimplementing the combo-box text for GTK only. Next patch will make that test cross platform (or at least I will try) and move it out to LayoutTests/accessibility.

> > Source/WebCore/accessibility/AccessibilityMenuList.cpp:117
> > +        // We need to ensure the popup has children before updating its active option to protect against
> > +        // situations like the one in accessibility/insert-selected-option-into-select-causes-crash.html.
> 
> This comment is too oblique. It doesn’t say what the problem is. But it could. Please be more specific about the problem in the comment.

Again, sorry. Next patch will hopefully explain it better :)

> > Source/WebCore/rendering/RenderMenuList.cpp:429
> > +    // Ensure that the passed index is in a valid range before updating accessibility.
> 
> This comment doesn’t seem helpful. The code says the same thing as the comment. The comment doesn’t say why or anything like that. Please add comments when they say something that the code does not say.

Ok, will remove it

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.