[Webkit-unassigned] [Bug 133512] [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133512





--- Comment #4 from Darin Adler <darin at apple.com>  2014-06-04 10:27:20 PST ---
(From update of attachment 232484)
View in context: https://bugs.webkit.org/attachment.cgi?id=232484&action=review

Looks like the fix is not entirely platform-specific, but the tests are. Any way we can do tests that can run on the other platforms too?

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:117
> +        // We need to ensure the popup has children before updating its active option to protect against
> +        // situations like the one in accessibility/insert-selected-option-into-select-causes-crash.html.

This comment is too oblique. It doesn’t say what the problem is. But it could. Please be more specific about the problem in the comment.

> Source/WebCore/rendering/RenderMenuList.cpp:429
> +    // Ensure that the passed index is in a valid range before updating accessibility.

This comment doesn’t seem helpful. The code says the same thing as the comment. The comment doesn’t say why or anything like that. Please add comments when they say something that the code does not say.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.