[Webkit-unassigned] [Bug 135358] [ftlopt] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135358


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com




--- Comment #11 from Geoffrey Garen <ggaren at apple.com>  2014-07-29 15:10:19 PST ---
> So:
> Debugger* debugger = globalObject->debugger();
> > +            if (debugger && debugger == this)
> > +                debugger->recompileAllJSFunctions(vm);
> 
> ==> becomes ==>
> 
> > +            if (debugger)
> > +                debugger->recompileAllJSFunctions(vm);

That's right.

It's not good to use 'this' unless we can guarantee that the object pointed to by 'this' has not been deleted.

It's not good to use a potentially deleted pointer -- even if you never dereference it. If the object pointed to by 'this' is deleted, and a new object is allocated in its place, then our "== this" comparison means something totally different, and probably wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.