[Webkit-unassigned] [Bug 135358] [ftlopt] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135358





--- Comment #10 from Saam Barati <sbarati at apple.com>  2014-07-29 12:22:53 PST ---
(In reply to comment #8)
> (From update of attachment 235648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235648&action=review
> 
> > Source/JavaScriptCore/ChangeLog:14
> > +        to being notified when the VM stops executing code via the event of the outermost 
> 
> "to being" ==> "for being"
> 
> > Source/JavaScriptCore/debugger/Debugger.cpp:345
> > +        auto listener = [this] (VM* vm, JSGlobalObject* globalObject) 
> > +        {
> > +            Debugger* debugger = globalObject->debugger();
> > +            if (debugger && debugger == this)
> > +                debugger->recompileAllJSFunctions(vm);
> > +        };
> > +
> > +        vm->entryScope->addEntryScopeDidPopListener(listener);
> 
> I just thought of an issue.  This code registers the listener, but you don't have any code to unregister it when the debugger is detached.  Please fix.

I'll create an interface for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.