[Webkit-unassigned] [Bug 135311] Web Inspector: shown() called on a content view when stepping over an instruction in the debugger

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135311





--- Comment #12 from Saam Barati <sbarati at apple.com>  2014-07-29 11:19:57 PST ---
(In reply to comment #8)
> 
> Do we really create a new ContentView?
> 

I'm not 100% sure on this. I think the more accurate statement is new BackForwardEntries are created.

> 
> That sounds unintentional. I think the back forward list should be for specific user events.
> 
>     1. Showing a ContentView, by clicking a Script/Resource Tree Element in the source sidebar
>     2. Jumping to a location by clicking a Breakpoint Tree Element in the debugger sidebar
>     3. Jumping to a location by clicking a CallFrame Tree Element in the debugger sidebar
>     4. Jumping to a location by clicking a (source:line:column) link anywhere in the UI
>     5. Hiding a ContentView, this may want to add a new entry or replace the current entry
> 
> I think stepping in the debugger it would be unexpected that that adds a new back/forward entry other than the possibility of normal navigation with (1) or (5).

Yeah that seems reasonable. I would also add that a new BackForwardEntry should be added when a debugger paused event causes you to move to a completely new location within the same file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.