[Webkit-unassigned] [Bug 135311] Web Inspector: shown() called on a content view when stepping over an instruction in the debugger

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 29 11:17:09 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=135311





--- Comment #11 from Timothy Hatcher <timothy at apple.com>  2014-07-29 11:17:22 PST ---
(In reply to comment #10)
> (In reply to comment #7)
> > It looks like this code is at fault:
> > 
> >         if (currentEntry && currentEntry.contentView === contentView && Object.shallowEqual(provisionalEntry.cookie, currentEntry.cookie))
> >             return currentEntry.contentView;
> > 
> > 
> > It only considers the cookie and view when testing if a new entry needs to be pushed. It should also compare scroll positions.
> 
> Okay, I'll look into it. I was actually looking at that code path earlier, and it actually does what it's supposed two thirds of the time. It seems like that code path is travelled down 3 times for each step-over, and on one of the three paths when stepping over, that test fails.

Three times sounds like two too many.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list