[Webkit-unassigned] [Bug 135358] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135358


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235630|1                           |0
        is obsolete|                            |




--- Comment #5 from Mark Lam <mark.lam at apple.com>  2014-07-28 16:28:40 PST ---
(From update of attachment 235630)
View in context: https://bugs.webkit.org/attachment.cgi?id=235630&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        tailored specifically for the Debugger and its purposes of recompiling all

typos in "its purposes of recompiling"?  Can it be phrased better?

> Source/JavaScriptCore/ChangeLog:14
> +        notified when the VMEntryScope dies. This creates a more generalized interface to 

... when the *outermost* VMEntryScope *exits* ...

> Source/JavaScriptCore/debugger/Debugger.cpp:341
> +            if (globalObject->debugger() && globalObject->debugger() == this) {
> +                this->recompileAllJSFunctions(vm);
> +            }

no need for { }

> Source/JavaScriptCore/runtime/VMEntryScope.cpp:71
> +        callback(&m_vm, m_globalObject);

nit: why not us a VM& instead of a VM*?

> Source/JavaScriptCore/runtime/VMEntryScope.h:47
> +    void addEntryScopeDidPopListener(EntryScopeDidPopListener lambda);

The "lambda" is not needed.  Please remove.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.